-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HOTFIX setup.py doesn't include materializations folder #45
Conversation
Issue
"include/sqlserver/macros/**/**/*.sql", This escaped our integration testing bc in in tox, we're not building a distribution and instead opting in install in development mode, something we've already remedied in dbt-sqlserver with dbt-msft/dbt-sqlserver#105. cc: @JCZuurmond Supporting Evidence@alieus and I were able to confirm this by:
TL;DRthis is because
does not glob in Python as I thought it would what I thought it would... what that
Discussion elsewherethis Slack thread documents the issue.
This also explains an internal thread (below) about why when I installed the package in development mode (
|
FYI we had the same problem in dbt-spark v0.19.0, and it escaped our notice in CI for the same reason. Here's the resolution we decided on: dbt-labs/dbt-spark#151 |
The approach @jtcohen6 shows looks fine to me |
fa53c2c
to
96a0a29
Compare
HOTFIX setup.py doesn't include materializations folder